Hi Takebe-san,
Ken'ichi Ohmichi wrote:
> Hi Takebe-san,
>
> Thank you for the patch.
>
> Akio Takebe wrote:
>> Curret kdump-xen with makdumpfile always return 0.
>> So if we fail to kdump, we will get $?=0.
>> This patch improve it.
>>
>> Signed-off-by: Akio Takebe <takebe_akio at jp.fujitsu.com>
>>
>> --- makedumpfile/makedumpfile.c 2008-03-28 11:32:51.000000000 +0900
>> +++ makedumpfile.mod/makedumpfile.c 2008-04-01 02:14:12.000000000 +0900
>> @@ -993,6 +993,8 @@ get_symbol_addr(char *symname)
>> if (!strcmp(sym_name, symname)) {
>> symbol = sym.st_value;
>> break;
>> + } else if (i >= (shdr.sh_size/shdr.sh_entsize)-1) {
>> + DEBUG_MSG("Can't get symbol of %s.\n", symname);
>
> This patch is for fixing error code of xen, but the above code adds
> the debugging message. So the above code doesn't match its purpose.
> Is it necessary ?
Sorry for incomprehensible comment.
The existences of symbols depend on linux version, cpu architecture,
and linux configuration (.config file). If the above code is merged,
the debugging message will be big and unreadable.
Do you want to know the lacks of necessary symbol for dump filtering
of Xen ? -D option prints them.
Thanks
Ken'ichi Ohmichi
