Re: [PATCH 02/20] crypto: Manual replacement of the deprecated strlcpy() with return values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Le jeu. 4 mars 2021 à 05:37, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> a écrit :
On Mon, Feb 22, 2021 at 04:12:13PM +0100, Romain Perier wrote:
>
> diff --git a/crypto/lrw.c b/crypto/lrw.c
> index bcf09fbc750a..4d35f4439012 100644
> --- a/crypto/lrw.c
> +++ b/crypto/lrw.c
> @@ -357,10 +357,10 @@ static int lrw_create(struct crypto_template *tmpl, struct rtattr **tb)
>        * cipher name.
>        */
>       if (!strncmp(cipher_name, "ecb(", 4)) {
> -             unsigned len;
> +             ssize_t len;

> -             len = strlcpy(ecb_name, cipher_name + 4, sizeof(ecb_name));
> -             if (len < 2 || len >= sizeof(ecb_name))
> +             len = strscpy(ecb_name, cipher_name + 4, sizeof(ecb_name));
> +             if (len == -E2BIG || len < 2)

len == -E2BIG is superfluous as len < 2 will catch it anyway.

Thanks,


Hello,

Yeah that's fixed in v2.

Thanks,
Romain

[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux