On Sun, Dec 06, 2020 at 12:09:31PM -0800, Sami Tolvanen wrote: > Sure, looks good to me. However, I think we should also test for > LLVM=1 to avoid possible further issues with mismatched toolchains > instead of only checking for llvm-nm and llvm-ar. It might still be worth testing for $(AR) and $(NM) because in theory, a user could say 'make AR=ar LLVM=1'. Highly unlikely I suppose but worth considering. Cheers, Nathan
