On Fri, 25 Feb 2022 05:24:27 +0700, Ammar Faizi wrote:
> Stack protector adds extra mov, extra stack allocation and extra branch
> to save and validate the stack canary. While this feature could be
> useful to detect stack corruption in some scenarios, it is not really
> needed for liburing which is simple enough to review.
>
> Good code shouldn't corrupt the stack. We don't need this extra
> checking at the moment. Just for comparison, let's take a hot function
> __io_uring_get_cqe.
>
> [...]
Applied, thanks!
[1/1] src/Makefile: Don't use stack protector for all builds by default
(no commit info)
Best regards,
--
Jens Axboe
