Since commit 8be8af4afcb4909104c ("queue: provide io_uring_get_sqe() symbol again"), we have the same defintion of `io_uring_get_sqe()` in queue.c and liburing.h. Make it simpler, maintain it in a single place, create a new static inline function wrapper with name `_io_uring_get_sqe()`. Then tail call both `io_uring_get_sqe()` functions to `_io_uring_get_sqe()`. Cc: Nugra <richiisei@xxxxxxxxx> Cc: Alviro Iskandar Setiawan <alviro.iskandar@xxxxxxxxxxx> Cc: GNU/Weeb Mailing List <gwml@xxxxxxxxxxxxxxxx> Cc: Tea Inside Mailing List <timl@xxxxxxxxxxxxxxxxxx> Cc: io-uring Mailing List <io-uring@xxxxxxxxxxxxxxx> Signed-off-by: Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> --- src/include/liburing.h | 9 +++++++-- src/queue.c | 11 +---------- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/src/include/liburing.h b/src/include/liburing.h index 590fe7f..ef5a4cd 100644 --- a/src/include/liburing.h +++ b/src/include/liburing.h @@ -831,8 +831,7 @@ static inline int io_uring_wait_cqe(struct io_uring *ring, * * Returns a vacant sqe, or NULL if we're full. */ -#ifndef LIBURING_INTERNAL -static inline struct io_uring_sqe *io_uring_get_sqe(struct io_uring *ring) +static inline struct io_uring_sqe *_io_uring_get_sqe(struct io_uring *ring) { struct io_uring_sq *sq = &ring->sq; unsigned int head = io_uring_smp_load_acquire(sq->khead); @@ -845,6 +844,12 @@ static inline struct io_uring_sqe *io_uring_get_sqe(struct io_uring *ring) } return sqe; } + +#ifndef LIBURING_INTERNAL +static inline struct io_uring_sqe *io_uring_get_sqe(struct io_uring *ring) +{ + return _io_uring_get_sqe(ring); +} #else struct io_uring_sqe *io_uring_get_sqe(struct io_uring *ring); #endif diff --git a/src/queue.c b/src/queue.c index 6b63490..f9b6c86 100644 --- a/src/queue.c +++ b/src/queue.c @@ -405,16 +405,7 @@ int io_uring_submit_and_wait(struct io_uring *ring, unsigned wait_nr) struct io_uring_sqe *io_uring_get_sqe(struct io_uring *ring) { - struct io_uring_sq *sq = &ring->sq; - unsigned int head = io_uring_smp_load_acquire(sq->khead); - unsigned int next = sq->sqe_tail + 1; - struct io_uring_sqe *sqe = NULL; - - if (next - head <= *sq->kring_entries) { - sqe = &sq->sqes[sq->sqe_tail & *sq->kring_mask]; - sq->sqe_tail = next; - } - return sqe; + return _io_uring_get_sqe(ring); } int __io_uring_sqring_wait(struct io_uring *ring) base-commit: 896a1d3ab14a8777a45db6e7b67cf557a44923fb -- 2.32.0