On Fri, Feb 25, 2022 at 5:25 AM Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> wrote: > Stack protector adds extra mov, extra stack allocation and extra branch > to save and validate the stack canary. While this feature could be > useful to detect stack corruption in some scenarios, it is not really > needed for liburing which is simple enough to review. > > Good code shouldn't corrupt the stack. We don't need this extra > checking at the moment. Just for comparison, let's take a hot function > __io_uring_get_cqe. Yes, I don't see any harm in removing the stack protector here. Reviewed-by: Alviro Iskandar Setiawan <alviro.iskandar@xxxxxxxxxxx> -- Viro
