On 12/14/20 12:43 PM, Bijan Mottahedeh wrote: > On 12/14/2020 11:29 AM, Jens Axboe wrote: >> On 12/14/20 12:09 PM, Bijan Mottahedeh wrote: >>> Just a ping. Anything I can do to facilitate the review, please let me >>> know. >> >> I'll get to this soon - sorry that this means that it'll miss 5.11, but >> I wanted to make sure that we get this absolutely right. It is >> definitely an interesting and useful feature, but worth spending the >> necessary time on to ensure we don't have any mistakes we'll regret >> later. > > Makes total sense. > >> >> For your question, yes I think we could add sqe->update_flags (something >> like that) and union it with the other flags, and add a flag that means >> we're updating buffers instead of files. A bit iffy with the naming of >> the opcode itself, but probably still a useful way to go. > > I'll look into that and we can fold it in the next round, would that work? That totally works, thanks. >> I'd also love to see a bunch of test cases for this that exercise all >> parts of it. >> > > Great idea. Should I send out the liburing changes and test cases now, > that would definitely help identify the gaps early. Yes, you can send them out now, and then we can just stuff them in a separate branch. Makes it easy to test and adapt to any potential kernel side changes as this is groomed for the next release. -- Jens Axboe
