Re: [PATCH v5 2/2] io_uring: avoid unnecessary io_wq_work copy for fast poll feature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hi,

On 08/06/2020 02:29, Jens Axboe wrote:
On 6/7/20 2:57 PM, Pavel Begunkov wrote:
-#define INIT_IO_WORK(work, _func)				\
+#define INIT_IO_WORK(work)					\
  	do {							\
-		*(work) = (struct io_wq_work){ .func = _func };	\
+		*(work) = (struct io_wq_work){};		\
  	} while (0)						\

Would be nice to optimize this one, it's a lot of clearing for something
we'll generally not use at all in the fast path. Or at least keep it
only for before when we submit the work for async execution.

Let's leave it to Xiaoguang and the series of the topic.
Yeah, I'd be glad to continue this job, thanks.

Regards,
Xiaoguang Wang


 From a quick look at this, otherwise looks great! Please do split and
submit this.

Sure. Have great time off!





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux