On 4/29/20 1:36 PM, Jann Horn wrote: > +linux-api > > On Wed, Apr 29, 2020 at 6:14 PM Jens Axboe <axboe@xxxxxxxxx> wrote: >> >> On 4/29/20 9:29 AM, Jens Axboe wrote: >>> On 4/29/20 9:26 AM, Christoph Hellwig wrote: >>>> On Wed, Apr 29, 2020 at 09:24:40AM -0600, Jens Axboe wrote: >>>>> >>>>> Not sure what the best fix is there, for 32-bit, your change will truncate >>>>> the offset to 32-bit as off_t is only 4 bytes there. At least that's the >>>>> case for me, maybe musl is different if it just has a nasty define for >>>>> them. >>>>> >>>>> Maybe best to just make them uint64_t or something like that. >>>> >>>> The proper LFS type would be off64_t. >>> >>> Is it available anywhere? Because I don't have it. >> >> There seems to be better luck with __off64_t, but I don't even know >> how widespread that is... Going to give it a go, we'll see. > > If you have questions about how to properly write UAPI headers, > linux-api@ is probably a good place to ask. This is in liburing, it's not the kernel side. The kernel side is fine. -- Jens Axboe
