On Thu, Feb 20, 2020 at 11:18 PM Jens Axboe <axboe@xxxxxxxxx> wrote: > On 2/20/20 3:14 PM, Jens Axboe wrote: > >>> @@ -3733,6 +3648,9 @@ static int io_poll_add_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe > >>> > >>> events = READ_ONCE(sqe->poll_events); > >>> poll->events = demangle_poll(events) | EPOLLERR | EPOLLHUP; > >>> + > >>> + /* task will wait for requests on exit, don't need a ref */ > >>> + req->task = current; > >> > >> Can we get here in SQPOLL mode? > > > > We can, this and the async poll arm should just revert to the old > > behavior for SQPOLL. I'll make that change. > > Actually, I think that should work fine, are you seeing a reason it > should not? Hm, no, I guess that might work.