On 2/20/20 3:14 PM, Jens Axboe wrote: >>> @@ -3646,46 +3596,11 @@ static int io_poll_wake(struct wait_queue_entry *wait, unsigned mode, int sync, >>> >>> list_del_init(&poll->wait.entry); >>> >> [...] >>> + tsk = req->task; >>> + req->result = mask; >>> + init_task_work(&req->sched_work, io_poll_task_func); >>> + sched_work_add(tsk, &req->sched_work); >> >> Doesn't this have to check the return value? > > Trying to think if we can get here with TASK_EXITING, but probably safer > to just handle it in any case. I'll add that. Double checked this one, and I think it's good as-is, but needs a comment. If the sched_work_add() fails, then the work item is still in the poll hash on the ctx. That work is canceled on exit. -- Jens Axboe
