On Wed, Jan 13, 2016 at 11:08 AM, Dave Gordon <david.s.gordon@xxxxxxxxx> wrote: > On 12/01/16 23:49, Chris Wilson wrote: >> >> On Tue, Jan 12, 2016 at 11:40:06PM +0000, Chris Wilson wrote: >>> >>> struct drm_i915_gem_object_ops { >>> + const unsigned int flags; >> >> >> Bleh, const is redundant as the definitions should be const themselves. >> -Chris > > > Yeah, the const-ness attaches to the instances of and references to the > structure rather than the abstract type. But it doesn't actually do any > harm, so with or without the redundant 'const' it gets: > > Reviewed-by: Dave Gordon <david.s.gordon@xxxxxxxxx> > Fixes the crash I was seeing with relocs in a userptr bo. Reviewed-by: Kristian Høgsberg <krh@xxxxxxxxxxxxx> _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx