Re: [PATCH] drm/i915: Allow i915_gem_object_get_page() on userptr as well

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/01/16 23:49, Chris Wilson wrote:
On Tue, Jan 12, 2016 at 11:40:06PM +0000, Chris Wilson wrote:
  struct drm_i915_gem_object_ops {
+	const unsigned int flags;

Bleh, const is redundant as the definitions should be const themselves.
-Chris

Yeah, the const-ness attaches to the instances of and references to the structure rather than the abstract type. But it doesn't actually do any harm, so with or without the redundant 'const' it gets:

Reviewed-by: Dave Gordon <david.s.gordon@xxxxxxxxx>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux