On Thu, Sep 03, 2015 at 06:33:25PM +0000, Konduru, Chandra wrote: > > > -----Original Message----- > > From: Daniel Vetter [mailto:daniel.vetter@xxxxxxxx] On Behalf Of Daniel Vetter > > Sent: Wednesday, September 02, 2015 1:02 AM > > To: Konduru, Chandra > > Cc: Daniel Vetter; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Vetter, Daniel; Syrjala, Ville > > Subject: Re: [PATCH 14/15] drm/i915: skl nv12 workarounds > > > > On Thu, Aug 27, 2015 at 01:44:06AM +0000, Konduru, Chandra wrote: > > > > > -static char intel_get_stepping(struct drm_device *dev) > > > > > +char intel_get_stepping(struct drm_device *dev) > > > > > > > > I guess we should have a new home for this now that it's used outside of > > > > intel_csr.c Plus kerneldoc, as usual. > > > > > > Will add kerneldoc header and respun, but where do you want to move to? > > > > If you want my dice-roll, I'd shovel it into intel_uncore.c for lack of > > better home. > > -Daniel > I sent updated patch series couple days ago moving to intel_display.c. > I hope that is fine. Imo intel_display.c is the wrong place since this isn't display-specific really - stepping is for the entire device. intel_uncore.c, i915_drv.c or i915_dma.c would all be suitable places. > By the way, can you start giving RB tags for the patches you reviewed? This isn't a full review, just a small thing I spotted while reading patches. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
