> > -static char intel_get_stepping(struct drm_device *dev)
> > +char intel_get_stepping(struct drm_device *dev)
>
> I guess we should have a new home for this now that it's used outside of
> intel_csr.c Plus kerneldoc, as usual.
Will add kerneldoc header and respun, but where do you want to move to?
>
> > {
> > if (IS_SKYLAKE(dev) && (dev->pdev->revision <
> > ARRAY_SIZE(skl_stepping_info)))
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> > index 419660d..2158b8f 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -3196,6 +3196,16 @@ static void skylake_update_primary_plane(struct
> drm_crtc *crtc,
> > I915_WRITE(PLANE_AUX_DIST(pipe, 0), aux_dist | aux_stride);
> > I915_WRITE(PLANE_AUX_OFFSET(pipe, 0), aux_y_offset << 16 |
> aux_x_offset);
> >
> > + DRM_DEBUG_KMS("KCM: is_skl = %d is_bxt = %d\n",
> > + IS_SKYLAKE(dev), IS_BROXTON(dev));
> > +
>
> Wa comments are missing here. Also generally we do 1 wa per commit.
> -Daniel
Sure, will split and respun.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
