> -----Original Message----- > From: Daniel Vetter [mailto:daniel.vetter@xxxxxxxx] On Behalf Of Daniel Vetter > Sent: Wednesday, September 02, 2015 1:02 AM > To: Konduru, Chandra > Cc: Daniel Vetter; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Vetter, Daniel; Syrjala, Ville > Subject: Re: [PATCH 14/15] drm/i915: skl nv12 workarounds > > On Thu, Aug 27, 2015 at 01:44:06AM +0000, Konduru, Chandra wrote: > > > > -static char intel_get_stepping(struct drm_device *dev) > > > > +char intel_get_stepping(struct drm_device *dev) > > > > > > I guess we should have a new home for this now that it's used outside of > > > intel_csr.c Plus kerneldoc, as usual. > > > > Will add kerneldoc header and respun, but where do you want to move to? > > If you want my dice-roll, I'd shovel it into intel_uncore.c for lack of > better home. > -Daniel I sent updated patch series couple days ago moving to intel_display.c. I hope that is fine. By the way, can you start giving RB tags for the patches you reviewed? > > > > > > > > > > { > > > > if (IS_SKYLAKE(dev) && (dev->pdev->revision < > > > > ARRAY_SIZE(skl_stepping_info))) > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c > > > b/drivers/gpu/drm/i915/intel_display.c > > > > index 419660d..2158b8f 100644 > > > > --- a/drivers/gpu/drm/i915/intel_display.c > > > > +++ b/drivers/gpu/drm/i915/intel_display.c > > > > @@ -3196,6 +3196,16 @@ static void > skylake_update_primary_plane(struct > > > drm_crtc *crtc, > > > > I915_WRITE(PLANE_AUX_DIST(pipe, 0), aux_dist | aux_stride); > > > > I915_WRITE(PLANE_AUX_OFFSET(pipe, 0), aux_y_offset << 16 | > > > aux_x_offset); > > > > > > > > + DRM_DEBUG_KMS("KCM: is_skl = %d is_bxt = %d\n", > > > > + IS_SKYLAKE(dev), IS_BROXTON(dev)); > > > > + > > > > > > Wa comments are missing here. Also generally we do 1 wa per commit. > > > -Daniel > > > > Sure, will split and respun. > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
