On Sat, Sep 13, 2014 at 05:23:23PM +0100, Chris Wilson wrote: > On Fri, Sep 12, 2014 at 08:53:35PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > IVB introduced the CUR_FBC_CTL register which allows reducing the cursor > > height down to 8 lines from the otherwise square cursor dimensions. > > Implement support for it. > > > > Commandeer the otherwise unused intel_crtc->cursor_size to track the > > current value of CUR_FBC_CTL so that we can avoid duplicating the > > complicated device type checks in i9xx_update_cursor(). > > > > One caveat to note is that CUR_FBC_CTL can't be used with 180 degree > > rotation, so when cursor rotation gets introduced some extra checks are > > needed. > > Where would be a good place to put that note into a comment? I guess I could stick it into cursor_size_ok(). > > So other than the mystery of rotated cursors, the code looks clear > enough. One side question, is the CHV/VLV conflation correct here? Yes. It's still the same old g4x derived display controller. -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
