On Fri, Sep 12, 2014 at 08:53:32PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > To make the code a bit more undestandable move the > intel_crtc->cursor_base assignment into the low level update cursor > routines. That's were we compare the current value with the new one > so immediately seeing that it gets assigned only afterwards helps > one to understand that it gets assigned only after the comparison. > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> I'd been tempted to do this myself, but lacked justification. Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx