On Fri, Jul 11, 2014 at 07:42:56AM +0100, Chris Wilson wrote: > On Fri, Jul 11, 2014 at 08:40:29AM +0200, Daniel Vetter wrote: > > On Thu, Jul 10, 2014 at 07:00:06PM +0100, Damien Lespiau wrote: > > > +typedef enum { > > > + /* this maps to the kernel API */ > > > + IGT_ROTATION_0 = 1 << 0, > > > + IGT_ROTATION_90 = 1 << 1, > > > + IGT_ROTATION_180 = 1 << 2, > > > + IGT_ROTATION_270 = 1 << 3, > > > +} igt_rotation_t; > > > > Should we also add the flip X/Y bits, even if we currently don't support > > this in the kernel? > > Presumably there are tests in here to check the kernel rejects > unsupported combination of rotations and unknown reflections? In which, > yes. I guess we should try everything and check whether it either gets rejected or works properly ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx