I've taken the current rotation test to test the kernel patches and improved it a bit along the way. It's a bit like a detailed review, but with patches instead of comments. With the rotation kernel patches and an IVB machine, that test now passes. Part of the motivation has been to augment the igt_kms framework to deal with properties. Another reason include the number of lines we need to write for a test. This series brings down that number from 325 to 129, something I can live with. HTH, -- Damien Damien Lespiau (42): igt_kms: Factor out a generic get_property() out of get_drm_plane_type() igt_kms: Make has_universal_planes a bitfield igt_kms: Provide a get_plane_property() shorthand igt_kms: Add a way to query of the plane supports rotation igt_kms: Add support for setting plane rotation igt_kms: Introduce a for_each_pipe() macro kms_rotation_crc: Make check_plane_type() static kms_rotation_crc: Make more functions static kms_rotation_crc: Align a few wrapped lines to the opening brace kms_rotation_crc: Update the copyright to have this year as well kms_rotation_crc: Test the validity of the output first kms_rotation_crc: Require universal planes for the testing primary rotation kms_rotation_crc: Fix style issue: '{' at the end of lines kms_rotation_crc: Fix style issue: single statement conditionals kms_rotation_crc: Factor out the square drawing function kms_rotation_crc: Factor out common primary/sprite code in prepare_crtc() kms_rotation_crc: Remove useless comments kms_rotation_crc: Use drm_plane from igt_plane_t kms_rotation_crc: Style issue: binary operators need spaces before and after kms_rotation_crc: Skip the tests if rotation is not supported kms_rotation_crc: Just store the igt_plane_t in data kms_rotation_crc: Unify the two tests kms_rotation_crc: Always disable the plane in cleanup kms_rotation_crc: Don't store rotate in the test state kms_rotation_crc: Don't store 'pipe' in the state kms_rotation_crc: Use igt_plane_set_rotation() kms_rotation_crc: Remove now unnecessary defines kms_rotation_crc: Use for_each_pipe() kms_rotation_crc: Remove the test on output->valid kms_rotation_crc: Remove 'output' from the state kms_rotation_crc: Remove the sleep(2) kms_rotation_crc: Remove plane from the state kms_rotation_crc: No need to test for NULL before freeing the pipe CRC object kms_rotation_crc: Allow the sprite test to run even without universal planes kms_rotation_crc: Don't commit with no fb set up kms_rotation_crc: Properly paint the whole frame buffer kms_rotation_crc: Add the test to .gitignore kms_rotation_crc: Don't compile the test on Android with no cairo support kms_rotation_crc: Document the two steps in prepare_crtc() kms_rotation_crc: Always use the primary plane to compute the reference CRC kms_rotation_crc: Remove unnecessary includes kms_rotation_crc: Use the igt_kms enum to encode the plane rotation Sonika Jindal (1): tests/kms_rotation_crc: IGT for 180 degree HW rotation lib/igt_kms.c | 114 ++++++++++++++++++++++--- lib/igt_kms.h | 26 +++++- tests/.gitignore | 1 + tests/Android.mk | 3 +- tests/Makefile.sources | 1 + tests/kms_rotation_crc.c | 214 +++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 344 insertions(+), 15 deletions(-) create mode 100644 tests/kms_rotation_crc.c -- 1.8.3.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx