On Mon, 2014-03-24 at 09:35 +0000, Daniel Vetter wrote: > On Mon, Mar 24, 2014 at 12:19:18PM +0530, sourab.gupta@xxxxxxxxx wrote: > > From: Sourab Gupta <sourab.gupta@xxxxxxxxx> > > > > This patch series adds rendering specific HW workarounds for VLV platform. > > These patches leads to stable behavior on VLV, especially > > when playing 3D Apps, benchmarks. > > > > Though, the patch set was submitter earlier, this new patch set is initiating > > a clean thread. We have addressed the comments on earlier patches and given > > the latest version of these patches in a single thread. > > > > Akash Goel (6): > > drm/i915/vlv: Added a rendering specific Hw WA > > 'WaTlbInvalidateStoreDataBefore' > > drm/i915/vlv: Added a rendering specific Hw WA > > 'WaSendDummy3dPrimitveAfterSetContext' > > drm/i915: Enabling the TLB invalidate bit in GFX Mode register > > drm/i915/vlv: Remove the enabling of VS_TIMER_DISPATCH bit in MI MODE > > reg > > drm/i915/vlv:Implement WaDisable_RenderCache_OperationalFlush > > drm/i915/vlv: Modified Implementation of WaDisableL3Bank2xClockGate > > Thanks for resending. But your patches are missing the in-patch changelogs > completely, which makes reviewing them hard - I have no idea what was > discussed already and why we've reached certain conclusions. Can you > please dig out the changelogs from older resends (I remember v2/v3/v4 of > some of your patches) and add this again? > > Also you missed e.g. Chris' tested-by on the tlb invalidation > optimization. And the commit message fails to state that you've only > tested this on vlv, but Chris has done the required testing on ivb/hsw. > > Such details are important in case the patch breaks something in the > future. > > One comment on one patch before I've noticed this, otherwise I think it's > better to wait for the resend. > > Thanks. Hi Daniel, Sorry for missing out on the in-patch changelogs. I'll add them to the patches and resend the set again. Regards, Sourab > > > > drivers/gpu/drm/i915/i915_gem_context.c | 65 ++++++++++++++++++++++++++++++++- > > drivers/gpu/drm/i915/i915_reg.h | 6 +++ > > drivers/gpu/drm/i915/intel_pm.c | 13 ++++++- > > drivers/gpu/drm/i915/intel_ringbuffer.c | 38 ++++++++++++++++++- > > drivers/gpu/drm/i915/intel_ringbuffer.h | 1 + > > 5 files changed, 117 insertions(+), 6 deletions(-) > > > > -- > > 1.8.5.1 > > > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
