Hi 2014/1/6 Damien Lespiau <damien.lespiau@xxxxxxxxx>: > Follow up of the v3: > http://lists.freedesktop.org/archives/intel-gfx/2013-December/037333.html > > The main change is the removal of INTEL_INFO() from the driver (patches 1 to > 5), a clean-up suggested by Chris: the usage of that macro hides that we go > from dev to dev_priv while we could use the dev_priv pointer that is usually > available. > > Patch 6 is also new, a minor clean-up while at it. For patches 1 to 6: Reviewed-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> Some comments/bikesheds (I'm not requiring these changes, just throwing some ideas): - You removed INTEL_INFO, but all those IS_SOMETHING and HAS_SOMETHING macros still accept dev as argument instead of dev_priv. Do we have plans to change this too? I can remember many places where I had to add a "dev" variable just because of these macros. Perhaps maybe the new goal is a series removing the to_i915 macro? I could see a lot of code getting almost entirely rid of "dev" with these changes. - It would be nice if we could come up with a clever strategy to find out if a still-not-initialized field of intel_device_info is being used. No clever ideas here, besides the obvious implementations that don't look good. - Quick! Merge patch 3 before it conflicts and someone needs to review that giant thing again! > > The remaining patches are rebased on top of the INTEL_INFO() change. > > -- > Damien > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Paulo Zanoni _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
