On Mon, 24 Feb 2025, Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> wrote: > Hi Ville, > > On Wed, Feb 12, 2025 at 01:19:37AM +0200, Ville Syrjala wrote: >> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> >> >> Convert the BDW+ EU/slice fuse bits to the modern REG_BIT()/etc. >> style. > > using REG_BIT() and co. doesn't alway make it more readable. In > some of the cases below I would have preferred not to use it. Interesting. I read through the patch and I thought all of it was good. Care to elaborate? BR, Jani. > > But on the other hand we keep consistency and bit operations are > not supposed to be easy-readable, anyway. > > Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> > > Thanks, > Andi -- Jani Nikula, Intel
