RE: [PATCH] drm/i915/pcode: Fix the coding style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> -----Original Message-----
> From: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> Sent: Tuesday, February 11, 2025 6:56 PM
> To: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>; Gote, Nitin R
> <nitin.r.gote@xxxxxxxxx>
> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH] drm/i915/pcode: Fix the coding style
> 
> On Mon, 10 Feb 2025, Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> wrote:
> > Hi Nitin,
> >
> > On Mon, Feb 10, 2025 at 07:39:24PM +0530, Nitin Gote wrote:
> >> Prefer binary operator at the end of the previous line instead of
> >> putting operator at the start of the next line as per coding style.
> >
> > I'm not finding any documentation for this change, where did you take
> > it?
> 
> If not documented, it's the prevalent style, anyway.

Yeah, My bad I thought it is a standard coding style but it is not so.
But still, I feel the more correct way is to use binary "|" operator in continuation of first line
instead of second line.

Thanks,
Nitin
> 
> BR,
> Jani.
> 
> 
> --
> Jani Nikula, Intel




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux