On Fri, Jan 31, 2025 at 05:16:29PM -0300, Gustavo Sousa wrote:
Quoting Krzysztof Karas (2025-01-30 11:18:28-03:00)
Hi Gustavo,
[...]
Let's remove that check, since it is unnecessary and causes the
inconsistency illustrated above.
Signed-off-by: Gustavo Sousa <gustavo.sousa@xxxxxxxxx>
---
Would you add:
Fixes: c01e78a96e12 ("drm/i915/dmc_wl: Sanitize enable_dmc_wl according to hardware support")?
I believe the above commit should not be a "fixes" candidate, the check
for intel_dmc_has_payload() was already there when that commit was
applied.
Also, do we need a "Fixes:" tag here? There only platform where the DMC
Wakelock mechanism is enabled by default is PTL, which is still under
force_probe protection.
it's not user visible, so no. Sometimes we may want to backport fixes
for platforms that may be used with previous kernel versions, but that
is mainly when we are close to remove the force_probe.
Lucas De Marchi
--
Gustavo Sousa
after that LGTM:
Reviewed-by: Krzysztof Karas <krzysztof.karas@xxxxxxxxx>
Krzysztof
