Re: [PATCH] drm/i915/display: convert intel_display_driver.[ch] to struct intel_display

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 04 Dec 2024, Gustavo Sousa <gustavo.sousa@xxxxxxxxx> wrote:
> Quoting Jani Nikula (2024-12-04 07:21:50-03:00)
>>Going forward, struct intel_display will be the main display driver
>>structure. Convert the main display entry points to struct
>>intel_display.
>>
>>Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
>>Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> Used b4 shazam followed by git show -W --word-diff and things look sane
> to me. So, also trusting the compiler,
>
> Reviewed-by: Gustavo Sousa <gustavo.sousa@xxxxxxxxx>

Thanks, pushed to din.

> Note: I found some places where the i915 variable could be dropped if we
> replaced &i915->drm with display->drm (calls to logging functions), but
> perhaps that was left for a future iteration.

Right, but all on the caller side, not within intel_display_driver.c. I
didn't want to expand the patch too much as it already touched quite a
lot.

BR,
Jani.


-- 
Jani Nikula, Intel



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux