Generic comments on these patches. These are enabling LOBF if it's possible. Possible errors are not taken into account. I think DP_ALPM_LOCK_TIMEOUT_ERROR should be taken into account in LOBF as well: See drivers/gpu/drm/i915/display/intel_psr.c:psr_alpm_check. You might also want to add some debug interface to disable lobf. I can imagine this being feature not working on all setups where possible on first try. Debugging/bisecting would be much easier if you have such interface. BR, Jouni Högander On Wed, 2024-12-04 at 15:33 +0530, Animesh Manna wrote: > Signed-off-by: Animesh Manna <animesh.manna@xxxxxxxxx> > > Animesh Manna (2): > drm/i915/lobf: Add lobf enablement in post plane update > drm/i915/lobf: Add debug print for LOBF > > drivers/gpu/drm/i915/display/intel_alpm.c | 29 > +++++++++++++++++++- > drivers/gpu/drm/i915/display/intel_alpm.h | 4 +++ > drivers/gpu/drm/i915/display/intel_display.c | 3 ++ > 3 files changed, 35 insertions(+), 1 deletion(-) >
