> -----Original Message----- > From: Nautiyal, Ankit K <ankit.k.nautiyal@xxxxxxxxx> > Sent: Wednesday, November 20, 2024 4:08 PM > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: intel-xe@xxxxxxxxxxxxxxxxxxxxx; Kandpal, Suraj <suraj.kandpal@xxxxxxxxx>; > jani.nikula@xxxxxxxxxxxxxxx; Deak, Imre <imre.deak@xxxxxxxxx> > Subject: [PATCH 02/12] drm/i915/dp: Return early if DSC not supported > > Check for DSC support before computing link config with DSC. > For DP MST we are already doing the same. > > Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > b/drivers/gpu/drm/i915/display/intel_dp.c > index db9ddbcdd159..dee15a05e7fd 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -2378,9 +2378,6 @@ int intel_dp_dsc_compute_config(struct intel_dp > *intel_dp, > intel_dp_supports_fec(intel_dp, connector, pipe_config) && > !intel_dp_is_uhbr(pipe_config)); > > - if (!intel_dp_supports_dsc(intel_dp, connector, pipe_config)) > - return -EINVAL; > - > if (!intel_dp_dsc_supports_format(connector, pipe_config- > >output_format)) > return -EINVAL; > > @@ -2643,6 +2640,9 @@ intel_dp_compute_link_config(struct intel_encoder > *encoder, > str_yes_no(ret), str_yes_no(joiner_needs_dsc), > str_yes_no(intel_dp->force_dsc_en)); > > + if (!intel_dp_supports_dsc(intel_dp, connector, pipe_config)) > + return -EINVAL; > + Mostly looks good to me but I was thinking what if we made intel_dp_supports_dsc one of the conditions that Determines if dsc is needed or not. Regards, Suraj Kandpal > if (!intel_dp_compute_config_limits(intel_dp, pipe_config, > > respect_downstream_limits, > true, > -- > 2.45.2
