On Tue, Nov 05, 2024 at 11:08:40AM +0200, Jani Nikula wrote: > On Tue, 05 Nov 2024, Vinod Govindapillai <vinod.govindapillai@xxxxxxxxx> wrote: > > Avoid using struct drm_i915_private reference and use intel_display > > instead. This is in preparation for the rest of the patches in this > > series where hw support for the minimum and interim ddb allocations > > for async flip is added > > This is technically correct, but it's self-contained in a single > function. I've preferred two approaches over this: > > - Convert entire files (sometimes internally first, with the external > interface changes in a separate patch, depending on how big the patch > becomes). > > - Convert single functions which are widely used and have struct > intel_display as parameter, to limit the size of the patch (as opposed > to doing the conversion as part of an entire file change). > > I think Ville said he's had a go at converting skl_watermark.c. Ville, > do you have a patch for that? Nothing usable atm. The unconverted dependecies at the time were rather extensive so it became a bit of a mess. I might have decent conversions for some of the dependencies though. I'll have a look around and post them if I see anything sane. -- Ville Syrjälä Intel
