On Thu, 10 Oct 2024, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > On Wed, Oct 09, 2024 at 01:20:53PM +0300, Jani Nikula wrote: >> On Wed, 09 Oct 2024, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: >> > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> >> > >> > Now that we use the gen3 codepaths also for gen2 >> > rename everything to gen2_ to match. >> >> This was fine for the gt stuff where there are gen5 and gen6 functions, >> but should we just call these something more generic since there are no >> platform specific functions? >> >> The naming is a bit funky already. >> >> intel_irq_init() is *not* the higher level function for init. It's >> actually intel_irq_install() -> intel_irq_postinstall() that calls >> gen3_irq_init() and some other stuff. > > intel_irq_init() seems like it should be ripped apart and distributed to > more appropriate places. The guc stuff at least. And most of the l3 > parity stuff also lives in some gt code, so the rest should probably > move as well (Either that or we rip out the wole thing. I suspect no > is actually using that anywhere). > > But no idea what to do about the gen2_ stuff. *shrug* I guess in the mean time we can go ahead with this. Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> -- Jani Nikula, Intel
