On Tue, Sep 17, 2024 at 08:43:50PM +0300, Jani Nikula wrote: > The tests consistently trigger WARNs in drm_framebuffer code. I'm not > sure what the point is with type of belts and suspenders tests. The > warnings *are* the way to flag erroneous API usage. > > Warnings in turn trigger failures in CI. Filtering the warnings are > error prone, and, crucially, would also filter actual errors in case the > kunit tests are not run. > > I acknowledge there may be complex test cases where you'd end up > triggering warnings somewhere deep, but these are not it. These are > simple. > > Revert the tests, back to the drawing board. Yeah I think long-term we might want a kunit framework so that we can catch dmesg warnings we expect and test for those, without those warnings actually going to dmesg. Similar to how the lockdep tests also reroute locking validation, so that the expected positive tests don't wreak lockdep for real. But until that exists, we can't have tests that splat in dmesg when they work as intended. Reviewed-by: Simona Vetter <simona.vetter@xxxxxxxx> Cheers, Sima > > BR, > Jani. > > > Cc: Carlos Eduardo Gallo Filho <gcarlos@xxxxxxxxxxx> > Cc: Maxime Ripard <mripard@xxxxxxxxxx> > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > Cc: Thomas Zimmermann <tzimmermann@xxxxxxx> > Cc: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> > > > Jani Nikula (2): > Revert "drm/tests: Add test for drm_framebuffer_free()" > Revert "drm/tests: Add test for drm_framebuffer_init()" > > drivers/gpu/drm/drm_framebuffer.c | 1 - > drivers/gpu/drm/drm_mode_object.c | 1 - > drivers/gpu/drm/tests/drm_framebuffer_test.c | 134 ------------------- > 3 files changed, 136 deletions(-) > > -- > 2.39.2 > -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
