[PATCH 0/2] drm: revert some framebuffer API tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The tests consistently trigger WARNs in drm_framebuffer code. I'm not
sure what the point is with type of belts and suspenders tests. The
warnings *are* the way to flag erroneous API usage.

Warnings in turn trigger failures in CI. Filtering the warnings are
error prone, and, crucially, would also filter actual errors in case the
kunit tests are not run.

I acknowledge there may be complex test cases where you'd end up
triggering warnings somewhere deep, but these are not it. These are
simple.

Revert the tests, back to the drawing board.

BR,
Jani.


Cc: Carlos Eduardo Gallo Filho <gcarlos@xxxxxxxxxxx>
Cc: Maxime Ripard <mripard@xxxxxxxxxx>
Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
Cc: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>


Jani Nikula (2):
  Revert "drm/tests: Add test for drm_framebuffer_free()"
  Revert "drm/tests: Add test for drm_framebuffer_init()"

 drivers/gpu/drm/drm_framebuffer.c            |   1 -
 drivers/gpu/drm/drm_mode_object.c            |   1 -
 drivers/gpu/drm/tests/drm_framebuffer_test.c | 134 -------------------
 3 files changed, 136 deletions(-)

-- 
2.39.2




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux