On Mon, Sep 09, 2024 at 06:21:49AM +0000, Garg, Nemesa wrote:
>
>
> > -----Original Message-----
> > From: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> > Sent: Tuesday, August 13, 2024 1:22 PM
> > To: Garg, Nemesa <nemesa.garg@xxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx;
> > Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx>
> > Cc: Garg, Nemesa <nemesa.garg@xxxxxxxxx>
> > Subject: Re: [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
> >
> > On Thu, 08 Aug 2024, Nemesa Garg <nemesa.garg@xxxxxxxxx> wrote:
> > > In panel fitter/pipe scaler scenario the pch_pfit configuration
> > > currently takes place before accounting for pipe_src width for joiner.
> > > This causes issue when pch_pfit and joiner get enabled together.
> > >
> > > Introduce a new boolean flag need_joiner which is set during dp
> > > compute_config in joiner case and later is used to compute
> > > panel_fitting in pipe_config. Modify pch_panel_fitting to handle
> > > joiner pipes by adjusting crtc_hdisplay accordingly.
> >
> > So I still don't like the fact that intel_panel_fitting() is called in different ways for
> > different connectors, controlled by a flag in crtc state.
> >
> > That said, I couldn't come up with a better idea either, apart from moving *all*
> > panel fitting intel_modeset_pipe_config().
> >
> > Cc: Ville, in case he has some ideas for this. Please hold off on merging until we
> > get some input from him.
> >
> > Hi Ville,
> Can you please suggest how should I proceed further on this patch.
I think we want to move the whole thing to happen after we've computed
final pipe_src and pipe_mode (which can then be used intead of
adjusted_mode in the pfit calculaitons).
The one annoying part of this is that we probably can only do it for the
ilk+ pfit ("pch"), but the old gmch pfit probably has to stay where it
is now because it may have to adjust the actual transcoder timings for
the purposes of adding borders.
Also I don't think we should really need any extra flags in the crtc
state. The pfit code should be able to figure it all out on its own.
--
Ville Syrjälä
Intel
