On Wed, Apr 03, 2024 at 04:52:37PM +0530, Balasubramani Vivekanandan wrote:
> From: José Roberto de Souza <jose.souza@xxxxxxxxx>
>
> Xe2_HPD has a different value to power down port A.
>
> BSpec: 65450
> CC: Matt Roper <matthew.d.roper@xxxxxxxxx>
> Signed-off-by: José Roberto de Souza <jose.souza@xxxxxxxxx>
> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@xxxxxxxxx>
Reviewed-by: Matt Roper <matthew.d.roper@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_cx0_phy.c | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> index 13a2e3db2812..caaae5d3758e 100644
> --- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> @@ -2921,17 +2921,28 @@ void intel_mtl_pll_enable(struct intel_encoder *encoder,
> intel_cx0pll_enable(encoder, crtc_state);
> }
>
> +static u8 cx0_power_control_disable_val(struct intel_encoder *encoder)
> +{
> + struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> +
> + if (intel_encoder_is_c10phy(encoder))
> + return CX0_P2PG_STATE_DISABLE;
> +
> + if (IS_BATTLEMAGE(i915) && encoder->port == PORT_A)
> + return CX0_P2PG_STATE_DISABLE;
> +
> + return CX0_P4PG_STATE_DISABLE;
> +}
> +
> static void intel_cx0pll_disable(struct intel_encoder *encoder)
> {
> struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> enum phy phy = intel_encoder_to_phy(encoder);
> - bool is_c10 = intel_encoder_is_c10phy(encoder);
> intel_wakeref_t wakeref = intel_cx0_phy_transaction_begin(encoder);
>
> /* 1. Change owned PHY lane power to Disable state. */
> intel_cx0_powerdown_change_sequence(encoder, INTEL_CX0_BOTH_LANES,
> - is_c10 ? CX0_P2PG_STATE_DISABLE :
> - CX0_P4PG_STATE_DISABLE);
> + cx0_power_control_disable_val(encoder));
>
> /*
> * 2. Follow the Display Voltage Frequency Switching Sequence Before
> --
> 2.25.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
