On Thu, Feb 15, 2024 at 06:40:44PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> intel_crtc_check_fastset() is done per-pipe, so it would be nice
> to know which pipe it was that failed its checkup.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 00ac65a14029..a7f487f5c2b2 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -5562,14 +5562,16 @@ static int intel_modeset_checks(struct intel_atomic_state *state)
> static void intel_crtc_check_fastset(const struct intel_crtc_state *old_crtc_state,
> struct intel_crtc_state *new_crtc_state)
> {
> - struct drm_i915_private *i915 = to_i915(old_crtc_state->uapi.crtc->dev);
> + struct intel_crtc *crtc = to_intel_crtc(new_crtc_state->uapi.crtc);
> + struct drm_i915_private *i915 = to_i915(crtc->base.dev);
>
> /* only allow LRR when the timings stay within the VRR range */
> if (old_crtc_state->vrr.in_range != new_crtc_state->vrr.in_range)
> new_crtc_state->update_lrr = false;
>
> if (!intel_pipe_config_compare(old_crtc_state, new_crtc_state, true))
> - drm_dbg_kms(&i915->drm, "fastset requirement not met, forcing full modeset\n");
> + drm_dbg_kms(&i915->drm, "[CRTC:%d:%s] fastset requirement not met, forcing full modeset\n",
> + crtc->base.base.id, crtc->base.name);
looking to other patches in this same series, I wonder
if we shouldn't benefit of a crct_dbg(crtc, "message") that would print
[CRTC:%d:%s] underneath.
But anyway,
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> else
> new_crtc_state->uapi.mode_changed = false;
>
> --
> 2.43.0
>
