> -----Original Message-----
> From: Govindapillai, Vinod <vinod.govindapillai@xxxxxxxxx>
> Sent: Wednesday, November 22, 2023 3:53 PM
> To: Kahola, Mika <mika.kahola@xxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH] drm/i915/display: Use int type for entry_setup_frames
>
> On Thu, 2023-11-16 at 11:05 +0200, Mika Kahola wrote:
> > entry_setup_frames variable is defined as u8. However, the function
> > call intel_psr_entry_setup_frames() can return negative error code.
> > There is a type mismatch here, so let's switch to use int here as
> > well.
> >
> > Fixes: 2b981d57e480 ("drm/i915/display: Support PSR entry VSC packet
> > to be transmitted one frame
> > earlier")
> >
> > Signed-off-by: Mika Kahola <mika.kahola@xxxxxxxxx>
> > ---
> > drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Vinod Govindapillai <vinod.govindapillai@xxxxxxxxx>
The patch is now merged. Thanks for the review!
-Mika-
>
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index 8d180132a74b..204da50e3f28 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -1319,7 +1319,7 @@ static bool _psr_compute_config(struct intel_dp
> > *intel_dp,
> > {
> > struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
> > const struct drm_display_mode *adjusted_mode =
> > &crtc_state->hw.adjusted_mode;
> > - u8 entry_setup_frames;
> > + int entry_setup_frames;
> >
> > /*
> > * Current PSR panels don't work reliably with VRR enabled
