> -----Original Message----- > From: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> > Sent: Wednesday, November 22, 2023 11:15 AM > To: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> > Cc: joonas.lahtinen@xxxxxxxxxxxxxxx; Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>; tvrtko.ursulin@xxxxxxxxxxxxxxx; airlied@xxxxxxxxx; > daniel@xxxxxxxx; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Jiapeng Chong > <jiapeng.chong@xxxxxxxxxxxxxxxxx>; Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>; Kahola, Mika <mika.kahola@xxxxxxxxx> > Subject: Re: [PATCH] drm/i915/psr: Fix unsigned expression compared with zero > > On Wed, 22 Nov 2023, Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> wrote: > > The entry_setup_frames is defined as u8 type, else(entry_setup_frames > > < 0) is invalid. At the same time, the return value of function > > intel_psr_entry_setup_frames is also of type int. so modified its type > > to int. > > > > ./drivers/gpu/drm/i915/display/intel_psr.c:1336:5-23: WARNING: Unsigned expression compared with zero: > entry_setup_frames >= 0. > > > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7610 > > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> > > There's already a patch. Mika, please follow up with it. > > https://patchwork.freedesktop.org/patch/msgid/20231116090512.480373-1-mika.kahola@xxxxxxxxx The patch is now merged. Thanks for the review. -Mika- > > > --- > > drivers/gpu/drm/i915/display/intel_psr.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c > > b/drivers/gpu/drm/i915/display/intel_psr.c > > index 8d180132a74b..204da50e3f28 100644 > > --- a/drivers/gpu/drm/i915/display/intel_psr.c > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > > @@ -1319,7 +1319,7 @@ static bool _psr_compute_config(struct intel_dp > > *intel_dp, { > > struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); > > const struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode; > > - u8 entry_setup_frames; > > + int entry_setup_frames; > > > > /* > > * Current PSR panels don't work reliably with VRR enabled > > -- > Jani Nikula, Intel
