> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Sent: Wednesday, November 15, 2023 11:58 PM
> To: Kahola, Mika <mika.kahola@xxxxxxxxx>
> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Hogander, Jouni <jouni.hogander@xxxxxxxxx>
> Subject: Re: [PATCH] drm/i915/mtl: Use int for entry setup frames
>
> On Mon, Nov 13, 2023 at 11:37:37AM +0200, Mika Kahola wrote:
> > At least one TGL had regression when using u8 types for entry setup
> > frames calculation. So, let's switch to use ints instead.
> >
> > Signed-off-by: Mika Kahola <mika.kahola@xxxxxxxxx>
> > ---
> > drivers/gpu/drm/i915/display/intel_psr.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index 3691f882e1c0..a4417e85f92a 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -1093,12 +1093,12 @@ static bool _compute_psr2_wake_times(struct intel_dp *intel_dp,
> > return true;
> > }
> >
> > -static u8 intel_psr_entry_setup_frames(struct intel_dp *intel_dp,
> > - const struct drm_display_mode *adjusted_mode)
> > +static int intel_psr_entry_setup_frames(struct intel_dp *intel_dp,
> > + const struct drm_display_mode *adjusted_mode)
> > {
> > struct drm_i915_private *i915 = dp_to_i915(intel_dp);
> > int psr_setup_time = drm_dp_psr_setup_time(intel_dp->psr_dpcd);
> > - u8 entry_setup_frames = 0;
> > + int entry_setup_frames = 0;
>
> You didn't change the other one in _psr_compute_config() so this still looks broken to me.
Indeed, I missed that one. Thanks for spotting!
-Mika-
>
> >
> > if (psr_setup_time < 0) {
> > drm_dbg_kms(&i915->drm,
> > --
> > 2.34.1
>
> --
> Ville Syrjälä
> Intel
