2013/9/24 Daniel Vetter <daniel@xxxxxxxx>: > On Mon, Sep 23, 2013 at 02:04:43PM -0300, Paulo Zanoni wrote: >> 2013/9/21 Daniel Vetter <daniel.vetter@xxxxxxxx>: >> > It only controls the setting of the vbt.edp_support variable, which in >> > turn only controls one debug output plus can also force-disable the >> > lvds output. >> > >> > Since the value only restricted this logic to mobile ilk there's the >> > slight risk that this will break lvds on desktop ilk or on snb/ivb >> > platforms. But with the vbt it's better when we know what's going on >> > here, so let's rip it out and see what happens. >> >> I think this is a little bit too risky, but the patch does what it >> says in the box and also mentions the risk... I was going to give a >> Reviewed-by tag and leave the merge-or-not-merge question to the >> maintainer, but I noticed the patch is already even merged (by >> accident?). > > I was lazy and didn't create a seperate branch for it ;-) Can I still > smash your r-b on top? Yes. Reviewed-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > >> Are we aware of any real-world machines with eDP + LVDS? > > I haven't seen any of those. What has been observed in the wild is lvds + > sdvo lvds, but I've never seen edp + some other panel anywhere ... Now that I think more about it, we only have 1 set of panel power sequencing registers. How would we do if we had 2 panels? > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- Paulo Zanoni _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx