On Wed, Sep 20, 2023 at 12:11:58PM +0300, Lisovskiy, Stanislav wrote: > On Thu, Sep 14, 2023 at 10:26:52PM +0300, Imre Deak wrote: > > If an MST stream is modeset, its state must be checked along all the > > other streams on the same MST link, for instance to resolve a BW > > overallocation of a non-sink MST port or to make sure that the FEC is > > enabled/disabled the same way for all these streams. > > > > To prepare for that this patch adds all the stream CRTCs to the atomic > > state and marks them for modeset similarly to tgl+ platforms. (If the > > state computation doesn't change the state the CRTC is switched back to > > fastset mode.) > > > > Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > index c1fea894d3774..832e8b0e87e84 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > @@ -491,9 +491,6 @@ intel_dp_mst_atomic_master_trans_check(struct intel_connector *connector, > > struct intel_connector *connector_iter; > > int ret = 0; > > > > - if (DISPLAY_VER(dev_priv) < 12) > > - return 0; > > - > > I'm just a bit concerned, why this check was initially added? > Probably there was a reason? It's in the name of the function, which should be renamed if we're extending it beyond its original purpose. > > Stan > > > if (!intel_connector_needs_modeset(state, &connector->base)) > > return 0; > > > > -- > > 2.37.2 > > -- Ville Syrjälä Intel
