On Friday, 15 September 2023 15:09:58 CEST Janusz Krzysztofik wrote: > Hi Mauro, > > On Friday, 15 September 2023 14:28:49 CEST Mauro Carvalho Chehab wrote: > > On Fri, 8 Sep 2023 14:32:47 +0200 > > Janusz Krzysztofik <janusz.krzysztofik@xxxxxxxxxxxxxxx> wrote: > > > > Forgot to mention on my past review: > > > > > + &n, &len) == 1 && len == strlen(buf))) { > > > + /* > > > + * TODO: drop the following workaround as soon as > > > + * kernel side issue of missing lines with top level > > > + * KTAP version and test suite plan is fixed. > > > + */ > > > > Please add a link to lore with the thread discussing the issue upstream, > > as it can be helpful while this workaround is here. > > > > Also, I would place the workaround on a separate patch, to make > > easier to revert it when upstream fixes it. > > Thanks for pointing that out. Since we already have those kernel changes > included in v6.6-rc1, then in drm-tip, I'll drop the workaround now. Or would you like, Mauro, to keep the workaround for CI testing of linux-xe not yet updated to v6.6-rc1? Thanks, Janusz > > Thanks, > Janusz >