Re: [PATCH i-g-t v2 13/17] lib/ktap: Reimplement KTAP parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri,  8 Sep 2023 14:32:47 +0200
Janusz Krzysztofik <janusz.krzysztofik@xxxxxxxxxxxxxxx> wrote:

Forgot to mention on my past review:

> +				       &n, &len) == 1 && len == strlen(buf))) {
> +		/*
> +		 * TODO: drop the following workaround as soon as
> +		 * kernel side issue of missing lines with top level
> +		 * KTAP version and test suite plan is fixed.
> +		 */

Please add a link to lore with the thread discussing the issue upstream,
as it can be helpful while this workaround is here.

Also, I would place the workaround on a separate patch, to make
easier to revert it when upstream fixes it.



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux