On Tue, 25 Apr 2023 13:19:25 -0700, John.C.Harrison@xxxxxxxxx wrote: > > @@ -3623,7 +3624,17 @@ decode_3d_965(struct intel_decode *ctx) > return len; > > case 0x7a00: > - if (IS_GEN6(devid) || IS_GEN7(devid)) { > + if (IS_GEN12(devid)) { > + if (len != 6) > + fprintf(out, "Bad count in PIPE_CONTROL\n"); > + instr_out(ctx, 0, "PIPE_CONTROL\n"); > + instr_out(ctx, 1, "flags\n"); > + instr_out(ctx, 2, "write address low\n"); > + instr_out(ctx, 3, "write address high\n"); > + instr_out(ctx, 4, "write data low\n"); > + instr_out(ctx, 5, "write data high\n"); > + return len; Is there a reference for this? I can review but have no idea what's going on here. The rest of the patch looks good. Thanks. > + } else if (IS_GEN6(devid) || IS_GEN7(devid)) { > if (len != 4 && len != 5) > fprintf(out, "Bad count in PIPE_CONTROL\n"); > > -- > 2.39.1 >