On Tue, 14 Feb 2023, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > We defined the bitmasks for DVSTILEOFF but never used them. > Remedy that. > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_sprite.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c > index e6b4d24b9cd0..a16e56a60c30 100644 > --- a/drivers/gpu/drm/i915/display/intel_sprite.c > +++ b/drivers/gpu/drm/i915/display/intel_sprite.c > @@ -1217,7 +1217,8 @@ g4x_sprite_update_arm(struct intel_plane *plane, > } > > intel_de_write_fw(dev_priv, DVSLINOFF(pipe), linear_offset); > - intel_de_write_fw(dev_priv, DVSTILEOFF(pipe), (y << 16) | x); > + intel_de_write_fw(dev_priv, DVSTILEOFF(pipe), > + DVS_OFFSET_Y(y) | DVS_OFFSET_X(x)); > > /* > * The control register self-arms if the plane was previously -- Jani Nikula, Intel Open Source Graphics Center
