On Tue, 14 Feb 2023, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > It's confusing to debug backlight issues when one can't > easily even tell what kind of backlight control was > selected. Sprinkle uniform debug messages to all the > backlight setup functions. > > Also the one that was already there (ext_pwm) was > using drm_info() for some reason. I don't think that's > warranted so switch it to drm_dbg_kms() as well. Maybe add similar in intel_dp_aux_backlight.c to the two setup functions there? Also the message in intel_backlight_setup() could use some tweaking. > @@ -1392,6 +1408,10 @@ static int vlv_setup_backlight(struct intel_connector *connector, enum pipe pipe > > panel->backlight.pwm_enabled = ctl2 & BLM_PWM_ENABLE; > > + drm_dbg_kms(&i915->drm, > + "[CONNECTOR:%d:%s] Using native PWM for backlight control\n", > + connector->base.base.id, connector->base.name); Maybe log the pipe here similar to controller in bxt/cnp? Otherwise, LGTM. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
