On Fri, 2022-11-18 at 13:37 -0800, Dixit, Ashutosh wrote: > On Fri, 18 Nov 2022 10:37:37 -0800, Vivi, Rodrigo wrote: > > > > On Sat, 2022-11-19 at 00:03 +0530, Badal Nilawar wrote: > > > From: Vinay Belgaumkar <vinay.belgaumkar@xxxxxxxxx> > > > > > > By defaut idle messaging is disabled for GSC CS so to unblock RC6 > > > entry on media tile idle messaging need to be enabled. > > > > > > v2: > > > - Fix review comments (Vinay) > > > - Set GSC idle hysteresis as per spec (Badal) > > > v3: > > > - Fix review comments (Rodrigo) > > > > > > Bspec: 71496 > > > > > > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> > > > Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@xxxxxxxxx> > > > Signed-off-by: Badal Nilawar <badal.nilawar@xxxxxxxxx> > > > Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar@xxxxxxxxx> > > > > He is the author of the patch, no?! > > or you can remove this or change the author to be you and keep his > > reviewed-by... > > > > or I can just remove his rv-b while merging.. just let me know.. > > Not sure if that is the case here, yeap, this is too small patch for that to happen. > but when multiple people contribute to a > patch, the original author can review changes by others and add his > Reviewed-by, no? Or are we saying it is redundant for the author to > add his > R-b? > > Similarly, are S-o-b and R-b by the same person ok? I add changes to > someone's patch so add my S-o-b but also review other's changes so > add my > R-b? Sometimes finding a 3rd person to add a R-b is hard. But two > poeple > can contribute to a patch and review each other's changes so add both > their > S-o-b's and R-b's or no? Definitely a case by case thing. If that happens it is good to have it clearly written in the commit message to know who did what, who reviewed what. Although I'd say that I'd still prefer the co-authored-by and having a third one doing the full review. > > :) > > Ashutosh >
