== Series Details == Series: Enable Pipewriteback (rev5) URL : https://patchwork.freedesktop.org/series/107440/ State : warning == Summary == Error: dim checkpatch failed 2ca799c55f17 drm/i915: Define WD trancoder for i915 -:69: CHECK:LINE_SPACING: Please don't use multiple blank lines #69: FILE: drivers/gpu/drm/i915/i915_reg.h:3710: + + total: 0 errors, 0 warnings, 1 checks, 194 lines checked ee9ce8f433d3 drm/i915 : Changing intel_connector iterators -:57: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #57: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1507: +#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \ + NULL : container_of(x, struct intel_connector, base)) -:57: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues #57: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1507: +#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \ + NULL : container_of(x, struct intel_connector, base)) -:85: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #85: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2093: + + } total: 0 errors, 0 warnings, 3 checks, 101 lines checked e608edbc4cb8 drm/i915: Enabling WD Transcoder Traceback (most recent call last): File "scripts/spdxcheck.py", line 11, in <module> import git ModuleNotFoundError: No module named 'git' Traceback (most recent call last): File "scripts/spdxcheck.py", line 11, in <module> import git ModuleNotFoundError: No module named 'git' -:144: WARNING:LONG_LINE: line length of 112 exceeds 100 columns #144: FILE: drivers/gpu/drm/i915/display/intel_display.c:1582: +static void intel_enable_writeback_capture(struct intel_atomic_state *state,struct intel_crtc_state *crtc_state) -:144: ERROR:SPACING: space required after that ',' (ctx:VxV) #144: FILE: drivers/gpu/drm/i915/display/intel_display.c:1582: +static void intel_enable_writeback_capture(struct intel_atomic_state *state,struct intel_crtc_state *crtc_state) ^ -:203: ERROR:OPEN_BRACE: that open brace { should be on the previous line #203: FILE: drivers/gpu/drm/i915/display/intel_display.c:7599: + if ((new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))) + { -:319: ERROR:TRAILING_WHITESPACE: trailing whitespace #319: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2085: +^I * An intel_connector entity is not created for a writeback $ -:559: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #559: new file mode 100644 -:597: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!job" #597: FILE: drivers/gpu/drm/i915/display/intel_wd.c:34: + if (job == NULL) { -:634: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #634: FILE: drivers/gpu/drm/i915/display/intel_wd.c:71: + DRM_ERROR("unsupported pixel format %x!\n", + pixel_format); -:712: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #712: FILE: drivers/gpu/drm/i915/display/intel_wd.c:149: + intel_de_write(i915, WD_STREAMCAP_CTL(intel_wd->trans), + *tmp); -:735: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #735: FILE: drivers/gpu/drm/i915/display/intel_wd.c:172: + memcpy(pipe_config, intel_crtc->config, + sizeof(*pipe_config)); -:786: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #786: FILE: drivers/gpu/drm/i915/display/intel_wd.c:223: + wakeref = intel_display_power_get_if_enabled(dev_priv, + encoder->power_domain); -:827: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #827: FILE: drivers/gpu/drm/i915/display/intel_wd.c:264: + drm_dbg_kms(&i915->drm, "Invalid framebuffer size %ux%u\n", + fb->width, fb->height); -:834: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #834: FILE: drivers/gpu/drm/i915/display/intel_wd.c:271: + drm_dbg_kms(&i915->drm, "Unsupported framebuffer format %08x\n", + fb->format->format); -:875: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #875: FILE: drivers/gpu/drm/i915/display/intel_wd.c:312: +static bool intel_fastset_dis(struct intel_encoder *encoder, + struct intel_crtc_state *pipe_config) -:929: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #929: FILE: drivers/gpu/drm/i915/display/intel_wd.c:366: + drm_encoder_helper_add(drm_enc, + &wd_encoder_helper_funcs); -:944: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #944: FILE: drivers/gpu/drm/i915/display/intel_wd.c:381: + err = drm_writeback_connector_init_with_encoder(&i915->drm, + wb_conn, drm_enc, &wb_connector_funcs, -:962: WARNING:RETURN_VOID: void function return statements are not generally useful #962: FILE: drivers/gpu/drm/i915/display/intel_wd.c:399: + return; +} -:1008: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1008: FILE: drivers/gpu/drm/i915/display/intel_wd.c:445: + intel_de_write(dev_priv, WD_SURF(intel_wd->trans), + i915_ggtt_offset(intel_wd->vma)); -:1019: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1019: FILE: drivers/gpu/drm/i915/display/intel_wd.c:456: + tmp = intel_de_read(dev_priv, + WD_STREAMCAP_CTL(intel_wd->trans)); -:1108: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1108: FILE: drivers/gpu/drm/i915/display/intel_wd.c:545: + if (intel_de_wait_for_set(dev_priv, PIPECONF(intel_wd->trans), + WD_TRANS_ACTIVE, 10)) -:1130: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1130: FILE: drivers/gpu/drm/i915/display/intel_wd.c:567: + ret = intel_wd_setup_transcoder(intel_wd, pipe_config, + conn_state, job); -:1179: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1179: FILE: drivers/gpu/drm/i915/display/intel_wd.c:616: +void intel_wd_enable_capture(struct intel_crtc_state *pipe_config, + struct drm_connector_state *conn_state) -:1196: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1196: FILE: drivers/gpu/drm/i915/display/intel_wd.c:633: + intel_wd_capture(intel_wd, pipe_config, + conn_state, job); -:1201: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1201: FILE: drivers/gpu/drm/i915/display/intel_wd.c:638: +void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *intel_crtc, + struct intel_crtc_state *intel_crtc_state) -:1241: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #1241: FILE: drivers/gpu/drm/i915/display/intel_wd.c:678: + for_each_intel_encoder(&i915->drm, encoder) { + -:1306: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1306: FILE: drivers/gpu/drm/i915/display/intel_wd.h:43: +void intel_wd_enable_capture(struct intel_crtc_state *pipe_config, + struct drm_connector_state *conn_state); -:1309: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1309: FILE: drivers/gpu/drm/i915/display/intel_wd.h:46: +void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *crtc, + struct intel_crtc_state *crtc_state); total: 3 errors, 3 warnings, 20 checks, 1260 lines checked
