On Tue, 16 Aug 2022, Lucas De Marchi <lucas.demarchi@xxxxxxxxx> wrote: > On Thu, Aug 11, 2022 at 06:07:24PM +0300, Jani Nikula wrote: >>diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h b/drivers/gpu/drm/i915/display/intel_display_core.h >>index 748d2a84e20e..f12ff36fef07 100644 >>--- a/drivers/gpu/drm/i915/display/intel_display_core.h >>+++ b/drivers/gpu/drm/i915/display/intel_display_core.h >>@@ -12,6 +12,7 @@ >> >> #include "intel_display.h" >> #include "intel_dmc.h" >>+#include "intel_dpll_mgr.h" >> #include "intel_gmbus.h" >> >> struct drm_i915_private; >>@@ -24,6 +25,7 @@ struct intel_color_funcs; >> struct intel_crtc; >> struct intel_crtc_state; >> struct intel_dpll_funcs; >>+struct intel_dpll_mgr; > > if you include intel_dpll_mgr.h you don't need the fwd declaration? Funny as it is, intel_dpll_mgr.h does not define or forward declare struct intel_dpll_mgr. :) BR, Jani. > > > Reviewed-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> > > > Lucas De Marchi -- Jani Nikula, Intel Open Source Graphics Center