== Series Details == Series: CDCLK churn: move checks to atomic check URL : https://patchwork.freedesktop.org/series/107522/ State : warning == Summary == Error: dim checkpatch failed c3061d754e21 drm/i915/display: Add CDCLK actions to intel_cdclk_state d6438fdf45eb drm/i915/squash: s/intel_cdclk_can_squash/intel_cdclk_squash -:43: CHECK:BRACES: braces {} should be used on all arms of this statement #43: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1751: + if (waveform && has_cdclk_squasher(dev_priv)) { [...] + } [...] -:62: CHECK:BRACES: Unbalanced braces around else statement #62: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1769: + } else -:97: ERROR:TRAILING_WHITESPACE: trailing whitespace #97: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1994: +^I$ total: 1 errors, 0 warnings, 2 checks, 103 lines checked 9f16f8721589 drm/i915/display: s/intel_cdclk_can_crawl/intel_cdclk_crawl -:23: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #23: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:41: +#define ADLP_CDCLK_CRAWL(dev_priv, vco) (HAS_CDCLK_CRAWL(dev_priv) && dev_priv->cdclk.hw.vco > 0 && vco > 0) -:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #23: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:41: +#define ADLP_CDCLK_CRAWL(dev_priv, vco) (HAS_CDCLK_CRAWL(dev_priv) && dev_priv->cdclk.hw.vco > 0 && vco > 0) -:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vco' - possible side-effects? #23: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:41: +#define ADLP_CDCLK_CRAWL(dev_priv, vco) (HAS_CDCLK_CRAWL(dev_priv) && dev_priv->cdclk.hw.vco > 0 && vco > 0) -:23: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'vco' may be better as '(vco)' to avoid precedence issues #23: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:41: +#define ADLP_CDCLK_CRAWL(dev_priv, vco) (HAS_CDCLK_CRAWL(dev_priv) && dev_priv->cdclk.hw.vco > 0 && vco > 0) -:99: ERROR:TRAILING_WHITESPACE: trailing whitespace #99: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1984: + ^I^Ia_div == b_div && $ -:99: ERROR:CODE_INDENT: code indent should use tabs where possible #99: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1984: + ^I^Ia_div == b_div && $ -:99: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #99: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1984: + ^I^Ia_div == b_div && $ -:99: WARNING:LEADING_SPACE: please, no spaces at the start of a line #99: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1984: + ^I^Ia_div == b_div && $ total: 2 errors, 3 warnings, 3 checks, 92 lines checked b882cdeeec1f drm/i915/display: Add cdclk checks to atomic check
