On Fri, 12 Aug 2022, "Murthy, Arun R" <arun.r.murthy@xxxxxxxxx> wrote:
>> +++ b/drivers/gpu/drm/i915/display/intel_display_core.h
>> @@ -0,0 +1,38 @@
>> +/* SPDX-License-Identifier: MIT */
>> +/*
>> + * Copyright © 2022 Intel Corporation
>> + */
>> +
>> +#ifndef __INTEL_DISPLAY_CORE_H__
>> +#define __INTEL_DISPLAY_CORE_H__
>> +
>> +#include <linux/types.h>
>> +
>> +struct intel_atomic_state;
>> +struct intel_crtc;
>> +struct intel_crtc_state;
>> +struct intel_initial_plane_config;
>> +
>> +struct intel_display_funcs {
>> + /* Returns the active state of the crtc, and if the crtc is active,
>> + * fills out the pipe-config with the hw state. */
> Can this be changed to multi-line commenting style.
Yeah.
> /*
> *
> */
>> + bool (*get_pipe_config)(struct intel_crtc *,
>> + struct intel_crtc_state *);
>> + void (*get_initial_plane_config)(struct intel_crtc *,
>> + struct intel_initial_plane_config *);
>> + void (*crtc_enable)(struct intel_atomic_state *state,
>> + struct intel_crtc *crtc);
>> + void (*crtc_disable)(struct intel_atomic_state *state,
>> + struct intel_crtc *crtc);
>> + void (*commit_modeset_enables)(struct intel_atomic_state *state);
>
> Can this be changed to something meaningful word, something like update_modeset()
It's already borderline doing too much in one patch to rename the
struct, and definitely too much to rename the hook. Maybe in another
patch.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
